[FFmpeg-devel] [PATCH v2 1/1] avcodec/vpp_qsv: Copy side data from input to output frame

[Anton Khirnov]

Quoting Soft Works (2021-12-03 09:51:13)
> > I'm concerned that this behavior will become hardcoded into this new API
> > and we won't be able to get rid of it in the future.
> 
> I understand your concern from an abstract point of view. But the point
> about which you want to be concerned has already happened 7 years ago
> and now there exist more than 200 usages of av_frame_copy_props(), all
> of which are possibly expecting the special treatment of PANSCAN.
> That makes me wonder, whether there might be any practical use for 
> a function av_frame_copy_side_data() that behaves differently?

I suspect the overwhelming majority of these calls are done between the
frames with the same resolution, so the relevant code is not executed.
The places where it does matter should be quite few.

And more generally, there's a lot of stuff in our codebase that
shouldn't be there. We shouldn't give up on improving things just
because they have been around for a long time.

-- 
Anton Khirnov