[FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

James Almer jamrial at gmail.com
Thu Dec 9 13:30:38 EET 2021



On 12/9/2021 8:21 AM, Lynne wrote:
> 9 Dec 2021, 11:14 by anton at khirnov.net:
> 
>> Quoting Lynne (2021-12-08 13:53:52)
>>
>>> That's not a goal, it's anti-goal, and a cause for hysterical raisin
>>> picking in the future.
>>> Having an instantly debuggable structure rather than one that
>>>
>>
>> Instantly debuggable structure?
>>
>> Again: very very little code needs to store actual AVChannels. In the
>> submitted tree this is just af_join. So the gain from adding an offset
>> would simplify very little code, while complicating all the callers
>> dealing with masks, of which there are quite many.
>>
> 
> It would make debugging much less hazardous,
> and any code that deals with masks uses the existing
> #defines. And even if it dealt directly, it's an offset that
> can be #defined so users could directly map wavetableext
> flags with a shift.

You're asking to make code uglier and harder to use, and to stray away 
from decades old standard mask conventions across software, for some 
supposed easier time debugging.
I'm with Anton and Hendrik, and i don't agree with this approach at all.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list