[FFmpeg-devel] [PATCH] MAINTAINERS: Add Haihao Xiang for vaapi

[Xu, Guangxin]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Michael Niedermayer
> Sent: Wednesday, December 15, 2021 5:40 AM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add Haihao Xiang for
> vaapi
> 
> On Tue, Dec 14, 2021 at 12:16:16PM -0800, Philip Langdale wrote:
> > On Tue, 14 Dec 2021 16:39:40 +0000
> > "Eoff, Ullysses A" <ullysses.a.eoff at intel.com> wrote:
> >
> > > I have not seen any objections.
> > > I just added Mark to CC using their email found on this ML.
> > > Unfortunately, we don't have current email contact for Gwenole (whom
> > > has not worked on ffmpeg for ~6 years).
> > > Who else can make the approval, aside from the inactive people
> > > previously listed?
> >
> > Are people reluctant to approve?
> 
> I dont think so, iam just extra carefull as someone on IRC noticed that
> "everyone and their grandmother who's worked for intel's got push access"

Lynne may have misunderstanding, as I know, the author he mentioned in IRC is not from Intel. 

> 
> There where also some complaints about code quality/cleanlyness toward
> intels contributions So i just wanted to make sure there are no objections
> (iam not conciously aware of any objections to these MAINTAINER additions
> ATM)

We care about the code quality, every patch sent to upstream will pass our internal review and ci test firstly. We defined an upstream process here https://github.com/intel-media-ci/cartwheel-ffmpeg#upstream-process.
If we missed something in the internal review, please give review comments during the public review. We will try our best to fix all issues. Push code only when it's no objections. 

We know the current code quality is not so good.  This is why we send many patches to improve it. But most of the patches are not merged since original maintainers are not so active. Having an active maintainer will help this. 
Haihao is a good candidate for the vaapi/qsv maintainer. He is the libva api maintainer for 10+ years. He will review and monitor all patches related to Intel. Hope this will address your code quality concerns.

> 
> 
> > I'll give it my approval to have on
> > the record. If the old maintainers want to emerge from the woodwork and
> > object after the fact, they are welcome to do so, but we can't just sit
> > around indefinitely. The contributions here are clear, and I can't see
> > either of them objecting, given my past interactions.
> 
> I suggest you apply these if noone raises any objections in the next
> 2-3 days, in fact people had a really long time already ...

Thank you Michael, Philip, Softworkz, U.Arite,  and all help on this.

> 
> thx
> 
> [...]
> --
> Michael     GnuPG fingerprint:
> 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Freedom in capitalist society always remains about the same as it was in
> ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin