[FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

[Nicolas George]

James Almer (12021-12-14):
> There's "char name[16]". Bigger than a pointer (Could be 8 bytes instead,
> but then it's kinda small). The user will not have to worry about the
> lifetime of anything then.

I find the fixed-size limiting. Please seriously consider the
alternative: AVChannelLayout is dynamically allocated and ref-counted,
and manages all the memory. If you consider this seriously (as a
complete redesign of the API, not as a small change), and think it is
not worth it, I will not insist and resign myself to fixed-size label +
opaque id.

But note that if Marton still wants more than a single fixed-size
string, I support.

> I'm attaching a diff that goes on top of the last patch of this set
> implementing this. It also adds support for these custom names to
> av_channel_layout_describe(), av_channel_layout_index_from_string() and
> av_channel_layout_channel_from_string(), including tests.

Thanks. Now we need the user interface: how does the user say “the left
channel with label "oboe"”? Probably something like "FL.oboe". The
parsing functions need to be adapted.

Regards,

-- 
  Nicolas George