[FFmpeg-devel] [PATCH 4/4] avcodec/tiff: Use ff_set_dimensions() for setting up mjpeg context dimensions

[Michael Niedermayer]

On Mon, Dec 20, 2021 at 10:51:56AM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2021-12-17 22:51:55)
> > Fixes: OOM
> 
> This is very non-obvious and could use more explanation.

I guess its obvious to me as ive seen this bug more than once
the problem is that directly setting width/height leaves
coded_w/h unset, then something sets coded_w/h and next time
width/height is set again it is unrelated to the still set
coded_w/h and theres a FFMAX() between coded_w and width
so the image allocated is much bigger
ff_set_dimension() breaks this chain by setting both width and
coded_width 

should i add this long explanation above to the commit message
or something shorter like
"sets coded_width / coded_height too to keep them consistent with
 width / height"
 
thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"You are 36 times more likely to die in a bathtub than at the hands of a
terrorist. Also, you are 2.5 times more likely to become a president and
2 times more likely to become an astronaut, than to die in a terrorist
attack." -- Thoughty2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20211220/5ab586cc/attachment.sig>