[FFmpeg-devel] [PATCH 1/2] avformat/mxf: support MCA audio information

Marton Balint cus at passwd.hu
Tue Dec 21 22:24:46 EET 2021



On Tue, 21 Dec 2021, Tomas Härdin wrote:

> tis 2021-12-21 klockan 11:44 +0100 skrev Marc-Antoine ARNAUD:
>> Le ven. 17 déc. 2021 à 19:12, Marton Balint <cus at passwd.hu> a écrit :
>> 
>> > 
>> > 
>> > On Fri, 17 Dec 2021, Marc-Antoine ARNAUD wrote:
>> > 
>> > > Hi all,
>> > > 
>> > > Can I have an update on this patch submission ?
>> > > Is something required to be done before it can be merged ?
>> > 
>> > New channel layout API is on its way, which makes in-demuxer
>> > channel
>> > reordering uneeded. Therefore the reordering option should not be
>> > added
>> > as it is in this patch. I can rework the patch after the channel
>> > layout
>> > API is in. (should happen in a couple of weeks at most).
>> > 
>> > Regards,
>> > Marton
>> > 
>> 
>> So it will happen only after the release 5 of FFMpeg right ?

Not sure. There were people who wanted the merge the channel layout api 
before the release.

>> 
>> Is it possible to merge it, and we can rework it after the new API is
>> released ?
>> Patches are related to IMF (new format) patches, and if FFmpeg can
>> accept
>> IMF without MCA support it will generate a lot of errors in audio
>> mapping.
>> So even if it's not performant for now, is it possible to imagine to
>> merge
>> patches and rework after ?
>
> I suspect this might create problems for the people writing the
> reordering API

It is not matter of performance, we should not introduce a hack such as 
reordering PCM channels in a demuxer if there is a better solution on the 
horizon.

If this is urgent, we could merge it without reordering support.

Regards,
Marton


More information about the ffmpeg-devel mailing list