[FFmpeg-devel] [PATCH 3/3] avformat/mov: remove always false condtion

[Gyan Doshi]

On 2021-12-24 03:52 pm, Steven Liu wrote:
>
>> 2021年12月24日 下午5:58，Zhao Zhili <quinkblack at foxmail.com> 写道：
>>
>> 203b0e35 made duration unsigned.
>> ---
>> libavformat/mov.c | 11 -----------
>> 1 file changed, 11 deletions(-)
>>
>> diff --git a/libavformat/mov.c b/libavformat/mov.c
>> index 63483740a0..636cfce400 100644
>> --- a/libavformat/mov.c
>> +++ b/libavformat/mov.c
>> @@ -3972,17 +3972,6 @@ static void mov_build_index(MOVContext *mov, AVStream *st)
>>
>>                  current_offset += sample_size;
>>                  stream_size += sample_size;
>> -
>> -                /* A negative sample duration is invalid based on the spec,
>> -                 * but some samples need it to correct the DTS. */
>> -                if (sc->stts_data[stts_index].duration < 0) {
>> -                    av_log(mov->fc, AV_LOG_WARNING,
>> -                           "Invalid SampleDelta %d in STTS, at %d st:%d\n",
>> -                           sc->stts_data[stts_index].duration, stts_index,
>> -                           st->index);
>> -                    dts_correction += sc->stts_data[stts_index].duration - 1;
>> -                    sc->stts_data[stts_index].duration = 1;
>> -                }
>>                  current_dts += sc->stts_data[stts_index].duration;
>>                  if (!dts_correction || current_dts + dts_correction > last_dts) {
>>                      current_dts += dts_correction;
>> -- 
>> 2.31.1

This is due to a recent change I made to the type of stts duration.

There is a pending patch to replace this check with a check in 
mov_read_stts, so ignore the warning for now.

Thanks,
Gyan