[FFmpeg-devel] [PATCH] libx264: Set min build version to 158

[Matt Oliver]

On Wed, 29 Dec 2021 at 23:37, Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Wed, Dec 29, 2021 at 05:16:25PM +1100, Matt Oliver wrote:
> > Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS"
> >
> > Setting X264_API_IMPORTS only affects msvc builds and it breaks linking
> to
> > static builds (although is required for shared builds). This flag is set
> by
> > x264 in its pkgconfig as required since build 158
> > (a615f027ed172e2dd5380e736d487aa858a0c4ff) from July 2019. So this patch
> > updates configure to require a newer x264 build that correctly sets the
> > imports flag.
> >
> > Alternatively we can detect the x264 build version in configure and keep
> > the fallback of manually setting the flag on older x264 builds that arent
> > using pkgconfig (to keep the old behaviour) but that requires some
> complex
> > configure changes.
> >
> > Signed-off-by: Matt Oliver <protogonoi at gmail.com>
> > ---
> >  configure            | 8 +++-----
> >  libavcodec/libx264.c | 4 ----
> >  2 files changed, 3 insertions(+), 9 deletions(-)
>
> I think this would effectivly drop ubuntu LTS support which seem to
> ship older versions
>
> thx
>

As I mentioned in the patch comments, if dropping pre 158 is not suitable
then some changes to configure could be made to fallback to old behaviour
but I'm not familiar enough with configure to do it. The configure check
would then need to be updated to do a pkg_config check if build 158 or
newer and if not then fallback to setting X264_API_IMPORTS on the command
line. This fallback still wouldnt allow static linking with msvc but that
is the current behaviour so it's not changing anything there. So some help
on what the correct configure changes should be would be appreciated.