[FFmpeg-devel] [PATCH v15 1/2] avformat/imf: Demuxer

[Paul B Mahol]

++i instead of i++

On Fri, Dec 31, 2021 at 11:40 AM Zane van Iperen <zane at zanevaniperen.com>
wrote:

>
>
> On 31/12/21 19:40, Paul B Mahol wrote:
> > Why was this applied?
>
> >>
> >> Both patches lgtm, I'll apply in a few days if no objections.
> >>
>
> No one objected.
>
>
> > It still breaks style of ffmpeg code, just from quick glance.
> >
> Which parts specifically?
>
> The main potential issue I can see is the long scanf() in
> ff_imf_xml_read_uuid().
> This, however, is only temporary as Pierre is working on replacing all the
> ad-hoc UUID
> stuff in ffmpeg with libuuid.
>
> If it's the av_log()s with parameters on newlines, that's also done in
> libavcodec/videotoolboxenc.c.
>
> If we're really *that* pedantic about it, I'll reformat things myself and
> submit a patch...
>
> > Please revert or I leave this project forever.
> >
>
> This is the internet, humor doesn't survive over email.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>