[FFmpeg-devel] [PATCH v6 2/3] avformat/mxf: add platform local tag

[Tomas Härdin]

mån 2021-02-01 klockan 22:54 +0800 skrev lance.lmwang at gmail.com:
> On Mon, Feb 01, 2021 at 12:01:02PM +0100, Tomas Härdin wrote:
> > mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmwang at gmail.com:
> > > From: Limin Wang <lance.lmwang at gmail.com>
> > > 
> > > Please check the string of platform with below command:
> > > ./ffmpeg -i ../fate-suite/mxf/Sony-00001.mxf -c:v copy -c:a copy out.mxf
> > > ./ffmpeg -i out.mxf
> > > ....
> > > application_platform: Lavf (linux)
> > > 
> > > Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> > > ---
> > >  configure                               | 1 +
> > >  libavformat/mxfenc.c                    | 4 ++++
> > >  tests/ref/fate/copy-trac4914            | 2 +-
> > >  tests/ref/fate/mxf-d10-user-comments    | 2 +-
> > >  tests/ref/fate/mxf-opatom-user-comments | 2 +-
> > >  tests/ref/fate/mxf-reel_name            | 2 +-
> > >  tests/ref/fate/mxf-user-comments        | 2 +-
> > >  tests/ref/fate/time_base                | 2 +-
> > >  tests/ref/lavf/mxf                      | 6 +++---
> > >  tests/ref/lavf/mxf_d10                  | 2 +-
> > >  tests/ref/lavf/mxf_dv25                 | 2 +-
> > >  tests/ref/lavf/mxf_dvcpro50             | 2 +-
> > >  tests/ref/lavf/mxf_opatom               | 2 +-
> > >  tests/ref/lavf/mxf_opatom_audio         | 2 +-
> > >  14 files changed, 19 insertions(+), 14 deletions(-)
> > > 
> > > diff --git a/configure b/configure
> > > index df298b4..a092a6b 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -7579,6 +7579,7 @@ cat > $TMPH <<EOF
> > >  #define FFMPEG_DATADIR "$(eval c_escape $datadir)"
> > >  #define AVCONV_DATADIR "$(eval c_escape $datadir)"
> > >  #define CC_IDENT "$(c_escape ${cc_ident:-Unknown compiler})"
> > > +#define OS_NAME $target_os
> > 
> > Is there some way to force a reconfigure? I got "Lavf (OS_NAME)" before
> > I re-ran ./configure. Not a huge issue however.
> 
> No, but I can check OS_NAME macro in the code, if it's not defined, 
> we can use "Lavf" instead of "Lavf (OS_NAME)"

Eh, don't bother. This is probably the case for a whole lot of other
defines.

I can apply this while I apply my MXF patch. Or did you have access to
git?

/Tomas