[FFmpeg-devel] [PATCH 01/50] avcodec/packet: deprecate av_init_packet()

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Mon Feb 8 16:43:27 EET 2021


James Almer:
> On 2/8/2021 11:37 AM, Andreas Rheinhardt wrote:
>> James Almer:
>>> On 2/4/2021 4:09 PM, James Almer wrote:
>>>> Once removed, sizeof(AVPacket) will stop being a part of the public
>>>> ABI.
>>>>
>>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>>> ---
>>>>    libavcodec/avpacket.c  | 23 +++++++++++++++--------
>>>>    libavcodec/packet.h    | 23 +++++++++++++++++++----
>>>>    libavcodec/version.h   |  3 +++
>>>>    libavformat/avformat.h |  4 ++++
>>>>    4 files changed, 41 insertions(+), 12 deletions(-)
>>>
>>> Will add APIChanges entry and version bump, and apply soon.
>>
>> Why the hurry? In fact, I have just sent a patchset that makes 3/50
>> redundant.
> 
> I'm talking about this patch, not the whole set. I'll give the rest some
> more time in case others want to review or test (The vaapi stuff i can't
> test, for example).
> 
> And yes, i saw the patches you sent that supersede 3/50, so assuming
> your set is ok i was going to withdraw it.
> 
I still don't see the reason to hurry things; actually I don't even this
direction at all, as it just leads to more allocations and frees. The dv
stuff is a good example of this, the mpegvideo_enc another.

- Andreas


More information about the ffmpeg-devel mailing list