[FFmpeg-devel] [PATCH v2] Add support for the new key & value API in libaom.

[Jan Ekström]

On Tue, Feb 9, 2021 at 6:05 AM Bohan Li
<bohanli-at-google.com at ffmpeg.org> wrote:
>
> This key & value API can greatly help with users who wants to try
> libaom-av1 specific options that are not supported by ffmpeg options.
>

Looks good to me code-wise at this point. Thanks for noticing the
small issues I had created due to not testing the modifications I did
late in the night :) .

I have tested this patch with both c1d42fe6615c96fc929257~1 (last
revision without this feature) and current libaom master, and both
compiled correctly. The error message from the library looks good
enough (in my case omochi=unyoon led to an "unknown option" error),
and the option is not available in the wrapper if the libaom version
built against didn't have it.

So two things I did:
- Adjust the author to match the name & e-mail in the Signed-off-by
(the mailing list changes the From field as it attempts to rewrite
fields when sending the messages out, so if you just apply the patch
from f.ex. Patchwork you get the wrong one).
- Rewrote the commit message.

https://github.com/jeeb/ffmpeg/commits/libaom_key_value_api_v2

Please tell if there are any issues with this from your side. If not,
I think we can start pulling this in :) .

Jan