[FFmpeg-devel] [PATCH] avformat/movenc: remove unnecessary HDR metadata log messages

[Anton Khirnov]

Quoting Jan Ekström (2021-02-10 00:31:51)
> These made sense before 3ebf449766d4b69a7774c4990fb24fe71c848a3e
> when the creation of these boxes was specifically requested by the
> user, but now they have become unnecessary as they are just like
> many other boxes: If the input has the information required, they
> are written, otherwise they are not.
> 
> They were moved to verbose verbosity level (which happens to be
> the last level still relatively usable), and now appear either once
> (normal MP4 muxing), or thrice (with the faststart flag set) in
> any normal MP4 usage, without giving much useful information. Thus,
> remove them in their current form.
> ---
> 
> For the record, I am not against having f.ex. the mdcv box writing function
> warning in case the side data is there, but it lacks the required information.
> 
> But just always logging this stuff, even if the user didn't go anywhere near
> streams with such information does not feel like something useful at this
> level of verbosity (esp. with the faststart flag causing it to appear thrice).
> 
> Jan
> 
> ---
>  libavformat/movenc.c | 2 --
>  1 file changed, 2 deletions(-)

av_log(NULL is evil, therefore I like this patch

-- 
Anton Khirnov