[FFmpeg-devel] [PATCH v5 01/10] cbs_h2645: refact, use cbs_h2645_replace_ps to replace cbs_h26*_replace_*ps

[Nuo Mi]

On Mon, Feb 15, 2021 at 3:45 AM Andreas Rheinhardt <
andreas.rheinhardt at gmail.com> wrote:

> Nuo Mi:
> > From: Mark Thompson <sw at jkqxz.net>
> >
> >
> > -}
> > +static int cbs_h2645_replace_ps(CodedBitstreamContext *ctx,
> > +                                CodedBitstreamUnit *unit)
> > +{
> > +    typedef struct {
> > +        int nal_unit_type;
> > +        int max_count;
> > +        const char *name;
>
> If this were a char name[4], these structs could be put in .rodata
> instead of .data (or .data.rel.ro) when using position-independent code.
>
thanks for the suggestion.
What's the benifite for this?
thanks

>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".