[FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: fix potential memory leak.

[Nicolas George]

Wonkap Jang (12021-02-16):
> While parsing ref_frame_config, AVdictionary needs to be manually
> deallocated.
> ---
>  libavcodec/libvpxenc.c | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)

NAK.

This code is all wrong, it looks like Java or Python, it should not be
using a dictionary in the first place, even less a dictionary stored in
the context. Just iterate over the key=value pairs of the string without
allocating all of them longer than necessary.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210217/34664439/attachment.sig>