[FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

James Almer jamrial at gmail.com
Sun Feb 21 20:02:12 EET 2021


On 2/21/2021 2:59 PM, Lynne wrote:
> Feb 21, 2021, 18:35 by jamrial at gmail.com:
> 
>> This callback is functionally the same as get_buffer2() is for decoders, and
>> implements for the new encode API the functionality of the old encode API had
>> where the user could provide their own buffers.
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> Used the names Lynne suggested this time, plus a line about how the callback
>> must be thread safe.
>>
>>   libavcodec/avcodec.h | 45 ++++++++++++++++++++++++++++++++++++
>>   libavcodec/codec.h   |  8 ++++---
>>   libavcodec/encode.c  | 54 +++++++++++++++++++++++++++++++++++++++++++-
>>   libavcodec/encode.h  |  8 +++++++
>>   libavcodec/options.c |  1 +
>>   5 files changed, 112 insertions(+), 4 deletions(-)

[...]

> I thought I suggested "encode", but I typed "encoder", sorry :(
> "encoder" looks worse. It's a nit, you don't have to send a new patch for it,
> but could you change everything to "encode" sometime before you push it?

Sure.

> Thanks.
> 
> With that change patch LGTM.

Will wait a bit to see if others want to comment, then push it after 
adding an APIChanges entry and version bump.


More information about the ffmpeg-devel mailing list