[FFmpeg-devel] [PATCH 1/3] avcodec/mjpegdec: Cleanup ff_smvjpeg_decoder()

Michael Niedermayer michael at niedermayer.cc
Mon Feb 22 18:57:05 EET 2021


On Thu, Feb 04, 2021 at 12:10:38PM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2020-12-20 22:15:22)
> > Fixes: memleaks
> > Fixes: 28533/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMVJPEG_fuzzer-6242529653686272
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/mjpegdec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c
> > index 11fb809c10..901ee228ab 100644
> > --- a/libavcodec/mjpegdec.c
> > +++ b/libavcodec/mjpegdec.c
> > @@ -3031,7 +3031,7 @@ AVCodec ff_smvjpeg_decoder = {
> >      .receive_frame  = ff_mjpeg_receive_frame,
> >      .flush          = decode_flush,
> >      .capabilities   = AV_CODEC_CAP_DR1,
> > -    .caps_internal  = FF_CODEC_CAP_INIT_THREADSAFE | FF_CODEC_CAP_EXPORTS_CROPPING |
> > +    .caps_internal  = FF_CODEC_CAP_INIT_THREADSAFE | FF_CODEC_CAP_INIT_CLEANUP | FF_CODEC_CAP_EXPORTS_CROPPING |
> 
> Please put it on the second line.
> 
> Looks good otherwise.

will apply with that changed

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210222/eff045ec/attachment.sig>


More information about the ffmpeg-devel mailing list