[FFmpeg-devel] [PATCH v2 1/3] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

[Nicolas George]

Jan Ekström (12021-01-13):
> Yea, I actually noticed that one, but never got to responding to it.
> Sorry about that.

No problem.

> While I do agree that such modes could be useful, currently I have no
> need for the additional modes and thus the original code by Stefano
> was just moved in avutil (and then utilized from ttmlenc). I did check
> the XML specification that this code originally seemed to follow the
> requirements (and thus mentioned the exact spot in the spec where this
> is mentioned).

Yes, it is technically correct. So would be escaping every character as
a numeric entity.

Adta' o elyraal,i t

XML is meant to be both machine-readable and human-readable. Escaping
unnecessarily pulls us away from human-readable.

> Thus, is the lack of those additional XML modes a blocker? Or should
> they be added as the need arises?

Considering that this is so simple that it would have taken you less
time to just do it than to wait for my answer, I would say that I insist
to do things properly immediately, before code starts piling on it and
requires to be revised.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210114/80687ef4/attachment.sig>