[FFmpeg-devel] [PATCH]lsws/ppc/yuv2rgb: Fix transparency converting from yuv->rgb32

[Carl Eugen Hoyos]

Am Sa., 23. Jan. 2021 um 19:16 Uhr schrieb Reimar Döffinger
<Reimar.Doeffinger at gmx.de>:
>
> Hi!
>
> > On 23 Jan 2021, at 17:31, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > Attached patch fixes ticket #9077 for me.
> >
> > Please comment, Carl Eugen
> > <0001-lsws-ppc-yuv2rgb-Fix-transparency-converting-from-yu.patch>
>
> Unfortunately I can’t test anything myself anymore since
> I don’t have any devices with VGA input anymore (and connecting
> the PPC MacMini via HDMI never worked reliably).
> But checking the surrounding code it might make sense to check
> if vec_splat(…{255}, 0) also works, or maybe even generates
> better code.
> The other cases where a non-0 constant (128) is needed in the
> whole vector use vec_splat instead of duplicating the value,
> so I assume there is a reason.
> In this case actually even more, since the code is generic and
> we might not actually know just how many 255s exactly we need
> to put into that array?

New patch attached, thank you!

Please comment, Carl Eugen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lsws-ppc-yuv2rgb-Fix-transparency-converting-from-yu.patch
Type: text/x-patch
Size: 1931 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210123/bda1a918/attachment.bin>