[FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

[Andreas Rheinhardt]

James Almer:
> On 1/24/2021 5:16 PM, Andreas Rheinhardt wrote:
>> It has been added in 6db42a2b6b22e6f1928fafcf3faa67ed78201004,
>> yet since then none of the necessary create/free_device_capabilities
>> functions has been implemented, making this API completely useless.
>>
>> Because of this one can already simplify
>> avdevice_capabilities_free/create and can already remove the function
>> pointers at the next major bump.
> 
> Not against it if nobody will bother to implement this on existing
> devices, but since the long term idea is to merge lavd into lavf, I
> assume the entirety of the library's API will be eventually deprecated
> and replaced.

I know that Anton is currently working on merging them, but I thought
that this would only involve compiling lavd into libavformat.so; not
that the API would be changed or the libavdevice/ source folder merged
into libavformat.

> Worth if anything to remove those AVOutputFormat/AVInputFormat function
> pointers, though.
> 
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
>> ---
>>   doc/APIchanges         |  4 ++++
>>   libavdevice/avdevice.c | 41 ++++++-----------------------------------
>>   libavdevice/avdevice.h |  5 +++++
>>   libavdevice/version.h  |  7 +++++--
>>   libavformat/avformat.h |  4 ++++
>>   5 files changed, 24 insertions(+), 37 deletions(-)
>>
>> diff --git a/doc/APIchanges b/doc/APIchanges
>> index bbf56a5385..8eeb6ba70f 100644
>> --- a/doc/APIchanges
>> +++ b/doc/APIchanges
>> @@ -15,6 +15,10 @@ libavutil:     2017-10-21
>>     API changes, most recent first:
>>   +2021-01-24 - xxxxxxxxxx - lavd 58.12.100 - avdevice.h
>> +  Deprecated avdevice_capabilities_create() and
>> +  Add avdevice_capabilities_free(). They
> 
> They?

"Add" is even bigger bullshit. Sorry.
(I swear I read this more than a dozen times.)

- Andreas