[FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

[lance.lmwang at gmail.com]

On Thu, Jan 28, 2021 at 02:41:46PM +0100, Tomas Härdin wrote:
> tor 2021-01-28 klockan 21:08 +0800 skrev lance.lmwang at gmail.com:
> > On Thu, Jan 28, 2021 at 10:26:03AM +0100, emcodem at ffastrans.com wrote:
> > > Am 2021-01-28 02:21, schrieb lance.lmwang at gmail.com:
> > > > I haven't found the s337m freely, so I'm not sure about the Platforma
> > > > metadata.
> > > > I think we haven't support the field yet, I guess it's 0x3C08 tag, but I
> > > > haven't
> > > > the document in hand so it's not OK to add it by me.
> > > > 
> > > Yeah the SMPTE are unfortunately not free :-(
> > > 
> > > Maybe this helps: a citate from 377-1-2009c which i believe is the only
> > > versoin of SMPTE 377 we should refer to unless we change the  "Minor
> > > Version" property of the partition pack to another value than "3" (which it
> > > currently is):
> > 
> > thanks, I got a copy already.
> > 
> > > > Item Name: Platform
> > > > Type: UTF-16 string
> > > > Len: var
> > > > Local Tag: 3C.08
> > > > Item UL:  06.0E.2B.3401.01.01.0205.20.07.0106.01.00.00
> > > > Req?: Opt
> > > > Meaning: Human readable name of the toolkit and operating system used.
> > > > Best practice is to use the form “SDK name (OS name)” [RP 210 Specifies
> > > > the platform on which the application was run]
> > 
> > I haven't figured out how to get the string of "OS name", maybe I had to
> > change configure file to add OS_NAME=$target_os and export the string.
> > 
> > Below is two example for Apple and Linux:
> >     application_platform: Lavf58.65.101(Darwin)
> >     application_platform: Lavf58.65.101(Linux)
> > 
> > If it's OK, I'll update the patch.
> 
> You're missing a space before the parentheses. But yeah, something like
> that would be fine with me. Maybe someone else has an opinion?

Have fixed it and send the updated patch, please help to review them.

> 
> /Tomas
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

-- 
Thanks,
Limin Wang