[FFmpeg-devel] [PATCH 3/4] avcodec/vp3: Check input amount in theora_decode_header()

[Peter Ross]

On Sat, Jan 30, 2021 at 04:00:20PM +0100, Michael Niedermayer wrote:
> Fixes: Timeout
> Fixes: 29226/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-6195092572471296
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/vp3.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c
> index 2a1da6b062..57c6eb1ff9 100644
> --- a/libavcodec/vp3.c
> +++ b/libavcodec/vp3.c
> @@ -2875,6 +2875,9 @@ static int theora_decode_header(AVCodecContext *avctx, GetBitContext *gb)
>      int ret;
>      AVRational fps, aspect;
>  
> +    if (get_bits_left(gb) < 206)
> +        return AVERROR_INVALIDDATA;
> +
>      s->theora_header = 0;
>      s->theora = get_bits(gb, 24);
>      av_log(avctx, AV_LOG_DEBUG, "Theora bitstream version %X\n", s->theora);
> -- 
> 2.17.1

ok

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210131/8ee174ac/attachment.sig>