[FFmpeg-devel] [PATCH 6/6] swscale: Make nonstatic identifiers respect the naming conventions

[Michael Niedermayer]

On Sat, Jan 30, 2021 at 05:44:24AM +0100, Andreas Rheinhardt wrote:
> swscale had several nonstatic functions and function pointers without
> the proper ff_-prefix; this has been fixed.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
> Tested on x86 and x64; I hope I did everything correct for the other
> arches, but I am not sure about that, therefore people with the
> necessary hardware will have to confirm this.
> 
>  libswscale/aarch64/rgb2rgb.c         |   4 +-
>  libswscale/arm/rgb2yuv_neon_common.S |   2 +-
>  libswscale/arm/swscale_unscaled.c    |   4 +-
>  libswscale/ppc/yuv2yuv_altivec.c     |   8 +-
>  libswscale/rgb2rgb.c                 | 178 ++++++++++++------------
>  libswscale/rgb2rgb.h                 | 196 +++++++++++++--------------
>  libswscale/rgb2rgb_template.c        |  92 ++++++-------
>  libswscale/swscale_unscaled.c        | 160 +++++++++++-----------
>  libswscale/tests/colorspace.c        |  72 +++++-----
>  libswscale/utils.c                   |   2 +-
>  libswscale/x86/rgb2rgb.c             |  18 +--
>  libswscale/x86/rgb2rgb_template.c    |  76 +++++------
>  tests/checkasm/sw_rgb.c              |  16 +--
>  13 files changed, 414 insertions(+), 414 deletions(-)

You are breaking the arm

src/libswscale/arm/swscale_unscaled.c: In function ‘rgbx_to_nv12_neon_32_wrapper’:
src/libswscale/arm/swscale_unscaled.c:41:5: error: implicit declaration of function ‘rgbx_to_nv12_neon_32’; did you mean ‘ff_rgbx_to_nv12_neon_32’? [-Werror=implicit-function-declaration]
     rgbx_to_nv12_neon_32(src[0] + srcSliceY * srcStride[0],
     ^~~~~~~~~~~~~~~~~~~~
     ff_rgbx_to_nv12_neon_32
src/libswscale/arm/swscale_unscaled.c: In function ‘rgbx_to_nv12_neon_16_wrapper’:
src/libswscale/arm/swscale_unscaled.c:55:5: error: implicit declaration of function ‘rgbx_to_nv12_neon_16’; did you mean ‘ff_rgbx_to_nv12_neon_16’? [-Werror=implicit-function-declaration]
     rgbx_to_nv12_neon_16(src[0] + srcSliceY * srcStride[0],
     ^~~~~~~~~~~~~~~~~~~~
     ff_rgbx_to_nv12_neon_16
cc1: some warnings being treated as errors


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210131/084bf6f0/attachment.sig>