[FFmpeg-devel] [PATCH 1/9] cbs_av1: fix incorrect data type

[James Almer]

On 6/17/2021 3:10 AM, Fei Wang wrote:
> shifted_order_hints is computed by data with int plus data with int.
> Switch to int8_t may lose its precision.
> 
> Signed-off-by: Fei Wang <fei.w.wang at intel.com>
> ---
>   libavcodec/cbs_av1_syntax_template.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/cbs_av1_syntax_template.c b/libavcodec/cbs_av1_syntax_template.c
> index 6fe6e9a4f3..956d45e132 100644
> --- a/libavcodec/cbs_av1_syntax_template.c
> +++ b/libavcodec/cbs_av1_syntax_template.c
> @@ -355,7 +355,7 @@ static int FUNC(set_frame_refs)(CodedBitstreamContext *ctx, RWContext *rw,
>           AV1_REF_FRAME_ALTREF2, AV1_REF_FRAME_ALTREF
>       };
>       int8_t ref_frame_idx[AV1_REFS_PER_FRAME], used_frame[AV1_NUM_REF_FRAMES];
> -    int8_t shifted_order_hints[AV1_NUM_REF_FRAMES];
> +    int shifted_order_hints[AV1_NUM_REF_FRAMES];

Would int16_t be enough? If so, use that.

LGTM either way.

>       int cur_frame_hint, latest_order_hint, earliest_order_hint, ref;
>       int i, j;
>   
>