[FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

[James Almer]

On 7/1/2021 1:25 PM, Thomas Volkert wrote:
> 
> On 01.07.2021 18:15, James Almer wrote:
>> On 7/1/2021 11:41 AM, James Almer wrote:
>>> On 7/1/2021 11:27 AM, Andreas Rheinhardt wrote:
>>>> James Almer:
>>>>> From: Matthieu Patou <mpatou at fb.com>
>>>>>
>>>>> Suggested-by: ffmpeg at fb.com
>>>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>>>> ---
>>>>>    libavformat/flv.h    |  1 +
>>>>>    libavformat/flvdec.c | 14 ++++++++++++--
>>>>>    2 files changed, 13 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/libavformat/flv.h b/libavformat/flv.h
>>>>> index 3571b90279..7a026d3217 100644
>>>>> --- a/libavformat/flv.h
>>>>> +++ b/libavformat/flv.h
>>>>> @@ -110,6 +110,7 @@ enum {
>>>>>        FLV_CODECID_H264    = 7,
>>>>>        FLV_CODECID_REALH263= 8,
>>>>>        FLV_CODECID_MPEG4   = 9,
>>>>> +    FLV_CODECID_H265    = 10,
>>>>>    };
>>>>
>>>> Is there an official source for these numbers?
>>>
>>> Apparently no. Neither does REALH263 or MPEG4 as far as i can see.
>>> But if there are files out there that can be demuxed with this
>>> change, as long as we don't support creating them, it should be fine.
>>
>> There was some discussion on IRC and an old trac ticket where we had
>> decided to strictly support only what Apple defined in the spec was
>> linked as reference, so I'm withdrawing this set.
> 
> I was also about to prepare a discussion mail against this patch set. We
> shouldn't fuzzy the spec.

Please do it, since Jean-Baptiste Kempf started a discussion on this set 
anyway.

> 
> So.. +1 for skipping this patch set.
> 
> Best regards.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>