[FFmpeg-devel] [PATCH] avfilter/f_metadata: do not return the frame early if there is no metadata

[Marton Balint]

On Wed, 23 Jun 2021, Marton Balint wrote:

>
>
> On Wed, 23 Jun 2021, Gyan Doshi wrote:
>
>> 
>> 
>> On 2021-06-23 06:11, Marton Balint wrote:
>>> The early return caused isses for the "add" mode (got fixed in
>>> c95dfe5cce98cde3e7fb14fbd04b3897f3927cec) and the "select" mode needs a 
>>> similar
>>> fix. It is probably better to fully remove the check, since all modes work
>>> correctly with NULL metadata.
>> 
>> Doesn't select mode imply the presence of a dictionary?
>
> Select mode selects frames with metadata, if there is no metadata the frame 
> should NOT be selected, but currently it is.

Will apply.

Regards,
Marton