[FFmpeg-devel] [PATCH 2/2] mov: Don't export unknown/unhandled metadata types as if they were UTF8

[Derek Buitenhuis]

On 4/1/2021 12:51 PM, Martin Storsjö wrote:
> +        } else if (data_type > 1 && data_type != 4) {
> +            // data_type can be 0 if not set at all above. data_type 1 means
> +            // UTF8 and 4 means "UTF8 sort". For any other type (UTF16 or e.g.
> +            // a picture), don't return it blindly in a string that is supposed
> +            // to be UTF8 text.
> +            av_log(c->fc, AV_LOG_WARNING, "Skipping unhandled metadata %s of type %d\n", key, data_type);
> +            av_free(str);
> +            return 0;

Should we add any UTF-8 validation on our end too?

- Derek