[FFmpeg-devel] [PATCH v7 1/8] libavcodec/qsv: enabling d3d11va support, added mfxhdlpair

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Xiang, Haihao
> Sent: Thursday, 15 July 2021 04:35
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v7 1/8] libavcodec/qsv: enabling
> d3d11va support, added mfxhdlpair
> 
> On Tue, 2021-07-13 at 11:53 -0300, James Almer wrote:
> > On 11/14/2020 1:49 PM, Max Dmitrichenko wrote:
> > > On Tue, Nov 3, 2020 at 7:47 PM Artem Galin <artem.galin at gmail.com>
> wrote:
> > >
> > > > Adding DX11 relevant device type checks and adjusting callbacks
> > > > with proper MediaSDK pair type support.
> > > >
> > > > Extending structure for proper MediaSDK pair type support.
> > > >
> > > > Signed-off-by: Artem Galin <artem.galin at intel.com> .....
> > >
> > >
> > > Patchset obviously closes the gap of DirectX 11 support and already
> > > checked with several apps that use FFMPEG.
> > >
> > > Any particular review comments should be yet expected?
> > >
> > > Changes seem to be straight forward
> > > and incorporate prev. comments.
> > >
> > > thank in advance
> > >
> > > regards
> > > Max
> >
> > There are some issues pointed out by Soft Works related to switching
> > the default to DX11 breaking existing command lines with DX9, plus an
> > OpenCL<->QSV interop regression this would introduce that according to
> > him should be easy to fix.
> >
> > If those are addressed, the set should be good.
> 
> If we may apply http://ffmpeg.org/pipermail/ffmpeg-devel/2021-
> June/281778.html
> (qsvdec: add support for HW_DEVICE_CTX method) first, we should be able
> to use the common device stuff to initialize d3d11va device for QSV and
> needn't use child_device_type to specify child device.

There's no doubt that the new method will be better, but the point is not to break existing command lines. From my experience, ffmpeg usually avoids to break established command line patterns, which is a good thing imo.

Anything more official than my perception? Please feel free to chime in... ;-)

softworkz

I