[FFmpeg-devel] [PATCH] fftools/ffmpeg: Add new variant source_no_drop to the force_key_frames option

[Thilo Borgmann]

Am 16.07.21 um 22:31 schrieb Mattias Wadman:
> On Fri, Jul 16, 2021 at 9:51 AM Thilo Borgmann <thilo.borgmann at mail.de>
> wrote:
> 
>> Am 04.07.21 um 21:23 schrieb Michael Niedermayer:
>>> On Sun, Jun 20, 2021 at 09:48:29PM +0200, Thilo Borgmann wrote:
>>>> Hi,
>>>>
>>>> adds a new variant to the -force_key_frames option "source_no_drop" to
>> make
>>>> sure whenever a key frame in the source is dropped, we choose the next
>> frame
>>>> in the output stream as a key frame.
>>>>
>>>> -Thilo
>>>
>>>>  doc/ffmpeg.texi  |    7 +++++++
>>>>  fftools/ffmpeg.c |    6 ++++++
>>>>  fftools/ffmpeg.h |    1 +
>>>>  3 files changed, 14 insertions(+)
>>>> e8ffd04204a6cc243b2f98858ec1f1afe44ff8e8
>> 0001-fftools-ffmpeg-Add-new-variant-source_no_drop-to-the.patch
>>>> From b37c854e7d48b538537b2c9c5e9651ba2ead3e52 Mon Sep 17 00:00:00 2001
>>>> From: Keyun Tong <ktong at fb.com>
>>>> Date: Sun, 20 Jun 2021 21:42:29 +0200
>>>> Subject: [PATCH] fftools/ffmpeg: Add new variant source_no_drop to the
>>>>  force_key_frames option
>>>
>>> LGTM if both variants have a use case
>>
>> Pushed.
> 
> 
> Sorry for late review, i just noticed this line:
> "!strncmp(ost->forced_keyframes, "source_no_drop", 6)"
> shouldn't it be:
> !strncmp(ost->forced_keyframes, "source_no_drop", 14)
> ?

Absolutely! Fixed and pushed, thanks!

-Thilo