[FFmpeg-devel] [PATCH] avformat/mov: Remove pointless EOF checks

Michael Niedermayer michael at niedermayer.cc
Sat Jul 24 18:25:01 EEST 2021


On Sat, Jul 24, 2021 at 06:35:14AM +0200, Andreas Rheinhardt wrote:
> 9888ffb1ce5e0a17f711b01933d504c72ea29d3b added checks for EOF
> in loops in the mov demuxer as a precaution against timeouts;
> yet there is no I/O in the loop when parsing the STSZ atom
> as the values are read from an already read buffer. So remove said
> checks.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>  libavformat/mov.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210724/335d0298/attachment.sig>


More information about the ffmpeg-devel mailing list