[FFmpeg-devel] [PATCH 3/3] libavcodec/mips: Fix fate errors reported by clang
yinshiyou-hf at loongson.cn
yinshiyou-hf at loongson.cn
Tue Jun 1 16:03:24 EEST 2021
> -----原始邮件-----
> 发件人: "Jin Bo" <jinbo at loongson.cn>
> 发送时间: 2021-05-28 10:04:41 (星期五)
> 收件人: ffmpeg-devel at ffmpeg.org
> 抄送: "Jin Bo" <jinbo at loongson.cn>
> 主题: [FFmpeg-devel] [PATCH 3/3] libavcodec/mips: Fix fate errors reported by clang
>
> The data width of gsldrc1/gsldlc1 should be 8 bytes wide.
>
> Signed-off-by: Jin Bo <jinbo at loongson.cn>
> ---
> libavcodec/mips/vp9_mc_mmi.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/libavcodec/mips/vp9_mc_mmi.c b/libavcodec/mips/vp9_mc_mmi.c
> index fa65ff5..812f7a6 100644
> --- a/libavcodec/mips/vp9_mc_mmi.c
> +++ b/libavcodec/mips/vp9_mc_mmi.c
> @@ -83,9 +83,9 @@ static void convolve_horiz_mmi(const uint8_t *src, int32_t src_stride,
> __asm__ volatile (
> "move %[tmp1], %[width] \n\t"
> "pxor %[ftmp0], %[ftmp0], %[ftmp0] \n\t"
> - "gsldlc1 %[filter1], 0x03(%[filter]) \n\t"
> + "gsldlc1 %[filter1], 0x07(%[filter]) \n\t"
> "gsldrc1 %[filter1], 0x00(%[filter]) \n\t"
> - "gsldlc1 %[filter2], 0x0b(%[filter]) \n\t"
> + "gsldlc1 %[filter2], 0x0f(%[filter]) \n\t"
> "gsldrc1 %[filter2], 0x08(%[filter]) \n\t"
> "li %[tmp0], 0x07 \n\t"
> "dmtc1 %[tmp0], %[ftmp13] \n\t"
> @@ -158,9 +158,9 @@ static void convolve_vert_mmi(const uint8_t *src, int32_t src_stride,
>
> __asm__ volatile (
> "pxor %[ftmp0], %[ftmp0], %[ftmp0] \n\t"
> - "gsldlc1 %[ftmp4], 0x03(%[filter]) \n\t"
> + "gsldlc1 %[ftmp4], 0x07(%[filter]) \n\t"
> "gsldrc1 %[ftmp4], 0x00(%[filter]) \n\t"
> - "gsldlc1 %[ftmp5], 0x0b(%[filter]) \n\t"
> + "gsldlc1 %[ftmp5], 0x0f(%[filter]) \n\t"
> "gsldrc1 %[ftmp5], 0x08(%[filter]) \n\t"
> "punpcklwd %[filter10], %[ftmp4], %[ftmp4] \n\t"
> "punpckhwd %[filter32], %[ftmp4], %[ftmp4] \n\t"
> @@ -254,9 +254,9 @@ static void convolve_avg_horiz_mmi(const uint8_t *src, int32_t src_stride,
> __asm__ volatile (
> "move %[tmp1], %[width] \n\t"
> "pxor %[ftmp0], %[ftmp0], %[ftmp0] \n\t"
> - "gsldlc1 %[filter1], 0x03(%[filter]) \n\t"
> + "gsldlc1 %[filter1], 0x07(%[filter]) \n\t"
> "gsldrc1 %[filter1], 0x00(%[filter]) \n\t"
> - "gsldlc1 %[filter2], 0x0b(%[filter]) \n\t"
> + "gsldlc1 %[filter2], 0x0f(%[filter]) \n\t"
> "gsldrc1 %[filter2], 0x08(%[filter]) \n\t"
> "li %[tmp0], 0x07 \n\t"
> "dmtc1 %[tmp0], %[ftmp13] \n\t"
> @@ -340,9 +340,9 @@ static void convolve_avg_vert_mmi(const uint8_t *src, int32_t src_stride,
>
> __asm__ volatile (
> "pxor %[ftmp0], %[ftmp0], %[ftmp0] \n\t"
> - "gsldlc1 %[ftmp4], 0x03(%[filter]) \n\t"
> + "gsldlc1 %[ftmp4], 0x07(%[filter]) \n\t"
> "gsldrc1 %[ftmp4], 0x00(%[filter]) \n\t"
> - "gsldlc1 %[ftmp5], 0x0b(%[filter]) \n\t"
> + "gsldlc1 %[ftmp5], 0x0f(%[filter]) \n\t"
> "gsldrc1 %[ftmp5], 0x08(%[filter]) \n\t"
> "punpcklwd %[filter10], %[ftmp4], %[ftmp4] \n\t"
> "punpckhwd %[filter32], %[ftmp4], %[ftmp4] \n\t"
> --
> 2.1.0
>
LGTM.</jinbo at loongson.cn></jinbo at loongson.cn></jinbo at loongson.cn>
More information about the ffmpeg-devel
mailing list