[FFmpeg-devel] [PATCH] lavfi/signature: fix always true expression

Valerii Zapodovnikov val.zapod.vz at gmail.com
Sat Jun 5 21:27:12 EEST 2021


пн, 24 мая 2021 г., 4:00 Valerii Zapodovnikov <val.zapod.vz at gmail.com>:

> Otherwise since "==" has higher precedence, mode is never checked.
> ---
>  libavfilter/signature_lookup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/signature_lookup.c
> b/libavfilter/signature_lookup.c
> index 272c717c77..85e879d224 100644
> --- a/libavfilter/signature_lookup.c
> +++ b/libavfilter/signature_lookup.c
> @@ -491,7 +491,7 @@ static MatchingInfo
> evaluate_parameters(AVFilterContext *ctx, SignatureContext *
>          meandist = (double) goodfcount / (double) distsum;
>
>          if (meandist < minmeandist ||
> -                status == STATUS_END_REACHED | STATUS_BEGIN_REACHED ||
> +                status == (STATUS_END_REACHED | STATUS_BEGIN_REACHED) ||
>                  mode == MODE_FAST){
>              minmeandist = meandist;
>              /* bestcandidate in this iteration */
> --
> 2.30.2
>

Ping. And sorry for duplication. I did it, not patchwork or whatever :(

>


More information about the ffmpeg-devel mailing list