[FFmpeg-devel] [PATCH] avcodec/libopenjpeg: Interpret cinema profiles as XYZ

[Michael Niedermayer]

On Sun, Jun 06, 2021 at 09:27:32AM +0300, Valerii Zapodovnikov wrote:
> From: Rémi Achard <remiachard at gmail.com>
> 
> Patch should be applied to decode XYZ samples with not native
> decoder in ffmpeg (-c:v libopenjpeg, not -c:v jpeg2000). jpeg2000
> works already.
> Now, this is AFAIK a patch that should be applied after upstream's
> patch: https://github.com/uclouvain/openjpeg/pull/1200
> Please note that jpeg2000 XYZ is not bitperfect compared to openjpeg
> see #4829#comment:3. Some pixels will be different, like in sYCC. I
> consider both bugs. Also pixel_format can be forced by
> "-pixel_format xyz12le".
> ---
>  libavcodec/libopenjpegdec.c | 44 +++++++++++++++++++++++--------------
>  1 file changed, 27 insertions(+), 17 deletions(-)

This breaks build

libavcodec/libopenjpegdec.c: In function ‘libopenjpeg_guess_pix_fmt’:
libavcodec/libopenjpegdec.c:203:14: error: ‘opj_image_t {aka const struct opj_image}’ has no member named ‘rsiz’
     if (image->rsiz == FF_PROFILE_JPEG2000_DCINEMA_2K ||
              ^~
libavcodec/libopenjpegdec.c:204:14: error: ‘opj_image_t {aka const struct opj_image}’ has no member named ‘rsiz’
         image->rsiz == FF_PROFILE_JPEG2000_DCINEMA_4K) {
              ^~
ffbuild/common.mak:67: recipe for target 'libavcodec/libopenjpegdec.o' failed
make: *** [libavcodec/libopenjpegdec.o] Error 1

changes to configure, version / feature checks are missing

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210606/ee1b6ca5/attachment.sig>