[FFmpeg-devel] [PATCH v2 14/22] lavfi/vpp_qsv: double the framerate for deinterlacing

[Linjie Fu]

Hi Haihao,

On Mon, May 17, 2021 at 11:30 AM Haihao Xiang <haihao.xiang at intel.com> wrote:
>
> ---
>  libavfilter/vf_vpp_qsv.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c
> index 29ba220665..ec35f85b04 100644
> --- a/libavfilter/vf_vpp_qsv.c
> +++ b/libavfilter/vf_vpp_qsv.c
> @@ -255,10 +255,14 @@ static int config_input(AVFilterLink *inlink)
>      int              ret;
>      int64_t          ow, oh;
>
> -    if (vpp->framerate.den == 0 || vpp->framerate.num == 0)
> +    /* Ignore user's setting for framerate when deinterlacing is used */
> +    if (vpp->deinterlace)
> +        vpp->framerate = av_mul_q(inlink->frame_rate,
> +                                  (AVRational){ 2, 1 });
> +    else if (vpp->framerate.den == 0 || vpp->framerate.num == 0)
>          vpp->framerate = inlink->frame_rate;

No objection, just considering would it be better to prompt a warning
for users instead of just ignoring the user 's setting?

- linjie