[FFmpeg-devel] [PATCH] lavf/rtmp: Add option to set TCP_NODELAY for rtmp

[Nicolas George]

Thilo Borgman (12021-06-09):
> $subject seems to be useful depending on the network.

It looks premature. TCP_NODELAY should only ever used when the network
code already takes care of writing data in a single system call. This is
not what happens in ff_rtmp_packet_write() (libavformat/rtmppkt.c): the
header is written separately.

Before allowing this option, this piece of code needs to be rewritten to
reduce system calls.

(TCP_NODELAY is a terrible hack for a terrible API design. An explicit
flush system call would have been a much better choice.)

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210609/50b34bd2/attachment.sig>