[FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

[Nicolas George]

Guo, Yejun (12021-03-01):
> private_ref is for internal use by a single libav* library.
> It has to be NULL when ownership of the frame leaves the respective library,
> 
> buffersink is the last step when the frame leaves libavfilter, so add unref here.
> 
> Signed-off-by: Guo, Yejun <yejun.guo at intel.com>
> ---
>  libavfilter/buffersink.c | 1 +
>  1 file changed, 1 insertion(+)

NAK. buffersink did not take ownership of that reference, therefore it
does not own it and cannot unref it.

If this change actually fixes something, i.e. if there is a ref at this
point, then we need to find who put it there, because they are
responsible for freeing it.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210301/ff7c1169/attachment.sig>