[FFmpeg-devel] [PATCH] lavc: clarify thread_safe_callbacks doxy

James Almer jamrial at gmail.com
Tue Mar 2 14:56:32 EET 2021


On 3/2/2021 6:10 AM, Anton Khirnov wrote:
> State explicitly when this field will be removed and how to access it in
> a forward compatible way.
> ---
>   libavcodec/avcodec.h | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index cd6e6d19bc..5a0904a854 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -1797,7 +1797,11 @@ typedef struct AVCodecContext {
>        *
>        * @deprecated the custom get_buffer2() callback should always be
>        *   thread-safe. Thread-unsafe get_buffer2() implementations will be
> -     *   invalid once this field is removed.
> +     *   invalid starting with LIBAVCODEC_VERSION_MAJOR=60; in other words,
> +     *   libavcodec will behave as if this field was always set to 1.
> +     *   Callers that want to be forward compatible with future libavcodec
> +     *   versions should wrap access to this field in
> +     *     #if LIBAVCODEC_VERSION_MAJOR < 60
>        */
>       attribute_deprecated
>       int thread_safe_callbacks;

LGTM.


More information about the ffmpeg-devel mailing list