[FFmpeg-devel] [PATCH V4 2/4] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

[Nicolas George]

Guo, Yejun (12021-03-04):
> For option 1.1, it is not allowed because .h file (structs for bounding box) for side
> data is not exported.
> 
> For option 1.2, to avoid the possible risk of API breaking, we need a versioning
> management, and the code such as BoundingBoxV1 and BoundingBoxV2 etc. is
> not elegant.

Have you considered option 1.3:

1.3. Add the enum for a new side data, but document:

/**
 * The data is for internal use by libavfilter.
 */

For the users, it is equivalent to storing it in private_ref, since it
is private, but it is closer to the good long-term API where the
information is eventually available outside.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210304/c928bc43/attachment.sig>