[FFmpeg-devel] [PATCH] avutil/hwcontext: add support to allow hardware to ref/unref frame

[Suji Velupillai]

Thank you Hendrik for your feedback.
Let me look into it addressing it.

Thank you
Suji

On Thu, Mar 4, 2021 at 12:11 AM Hendrik Leppkes <h.leppkes at gmail.com> wrote:

> On Thu, Mar 4, 2021 at 7:20 AM <suji.velupillai at broadcom.com> wrote:
> >
> > From: Patrick Rault <patrick.rault at broadcom.com>
> >
> > Add support to allow attached hardware to add/remove reference to the
> > frame buffer mirroring the ffmpeg.
> >
> > Signed-off-by: Patrick Rault <patrick.rault at broadcom.com>
> > Signed-off-by: Suji Velupillai <suji.velupillai at broadcom.com>
>
> New API additions should include an explanation of which problems this
> solves, how it should be used, and why it is necessary. Otherwise we
> have no reference to even judge the usefulness of such an API.
>
> Looking at the patch, the change to av_frame_ref looks fishy to me.
> Why would dst reference itself, and not src?
>
> - Hendrik
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4218 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210304/80f0104d/attachment.bin>