[FFmpeg-devel] [PATCH 7/8] avcodec/cbs_sei: Fix leak of AVBufferRef on error

[Mark Thompson]

On 10/03/2021 01:06, Andreas Rheinhardt wrote:
> An AVBufferRef (and the corresponding AVBuffer and the underlying actual
> buffer) would leak in ff_cbs_sei_add_message() on error in case an error
> happened after its creation and before it has been attached to more
> permanent storage. Fix this by only creating the AVBufferRef immediately
> before attaching it to its intended target position.
> 
> (Given that no SEI message currently created is refcounted, the above
> can't happen at the moment. But Coverity already nevertheless noticed:
> This commit fixes Coverity issue #1473521.)
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>   libavcodec/cbs_sei.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> ...

Patches 1, 6, 7 LGTM.

Thanks,

- Mark