[FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

[Marton Balint]

On Sat, 13 Mar 2021, Paul B Mahol wrote:

> On Sat, Mar 13, 2021 at 5:56 PM Marton Balint <cus at passwd.hu> wrote:
>
>>
>>
>> On Fri, 12 Mar 2021, Paul B Mahol wrote:
>>
>> > On Fri, Mar 12, 2021 at 12:21 AM Marton Balint <cus at passwd.hu> wrote:
>> >
>> >>
>> >>
>> >> On Sun, 7 Mar 2021, Marton Balint wrote:
>> >>
>> >> >
>> >> >
>> >> > On Sun, 7 Mar 2021, Paul B Mahol wrote:
>> >> >
>> >> >> On Sun, Mar 7, 2021 at 9:02 AM Marton Balint <cus at passwd.hu> wrote:
>> >> >>
>> >> >>>
>> >> >>>
>> >> >>> On Sun, 7 Mar 2021, Paul B Mahol wrote:
>> >> >>>
>> >> >>> > On Sun, Mar 7, 2021 at 1:57 AM James Almer <jamrial at gmail.com>
>> >> wrote:
>> >> >>> >
>> >> >>> >> On 3/6/2021 9:51 PM, Paul B Mahol wrote:
>> >> >>> >> > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint <cus at passwd.hu>
>> >> wrote:
>> >> >>> >> >
>> >> >>> >> >>
>> >> >>> >> >>
>> >> >>> >> >> On Sun, 7 Mar 2021, Paul B Mahol wrote:
>> >> >>> >> >>
>> >> >>> >> >>> How you tested this?
>> >> >>> >> >>
>> >> >>> >> >> with the librist tools.
>> >> >>> >> >>
>> >> >>> >> >>>
>> >> >>> >> >>> And why you have not asked nicely before taking working on
>> this?
>> >> >>> >> >>
>> >> >>> >> >> You wrote you have given up. It is your behaviour which is not
>> >> very
>> >> >>> >> nice.
>> >> >>> >> >> After your continuous ignorance of my requests, I try to help
>> >> your
>> >> >>> work
>> >> >>> >> >> get merged, and this is your feedback...
>> >> >>> >> >>
>> >> >>> >> >
>> >> >>> >> >
>> >> >>> >> > Why are you so aggressive? Other devs raised issues that looks
>> not
>> >> >>> >> resolved.
>> >> >>> >>
>> >> >>> >> I don't see aggressiveness from his part. I see you making things
>> >> >>> >> incredibly more complex than they should be.
>> >> >>> >>
>> >> >>> >
>> >> >>> > The code in functional part is not much different from initial
>> >> versions.
>> >> >>> >
>> >> >>> > So I really doubt that fifo filling up issue have been properly
>> >> >>> addressed.
>> >> >>>
>> >> >>> I can take a look at that if you provide command lines to reproduce.
>> >> >>>
>> >> >>
>> >> >> I couldn't reproduce it, so you have to ask others.
>> >> >
>> >> > I found one issue in librist code which can be related and might cause
>> >> > ffmpeg not to recover from a fifo fillup. I have reported it here:
>> >> >
>> >> > https://code.videolan.org/rist/librist/-/issues/93
>> >>
>> >> I'd love to see rist support in 4.4, so maybe we should apply this
>> series
>> >> as is and fix any remaining issues later...
>> >>
>> >
>> >
>> > Not gonna block it.
>>
>> OK, will apply.
>>
>
> IIRC librist have not released new release yet, and configure check does
> not check for new functions that are required for building.

They are still at 0.2 RC something and we require 0.2. I thought that 
means the stable 0.2 release, so we are good. But yes, if somebody uses an 
earlier RC from git, it might not work correctly. Is that something we 
should fix? I am not sure.

Regards,
Marton