[FFmpeg-devel] [PATCH] avcodec/dv_profile: PAL DV files with dsf flag 0 - detect via pal flag and buf_size

[Marton Balint]

On Thu, 18 Mar 2021, Mark Plomer wrote:

> Okay cool, I added the check for the PAL flag - this still works fine for my 
> test-videos.
>
> I also looked at the old hack above with the codec_tag check - changed in 
> 2013 for ticket #2177 (patch by Michael Niedermayer). I removed that more 
> specific hack and the test-video attached to ticket #2177 also runs into the 
> new hack now ... and still works fine. It also has a "dsf = 0" flag, though 
> it is PAL.
>
> So it was really a good idea to consolidate those hacks! Maybe the whole 
> generic matching logic should be refactored, to match against the pal flag 
> instead of the dsf flag? (The "buf_size" check may also be obsolete then). 
> But this will be another task ;-)
>
> I attached the updated patch.

It looks good to me, I will apply in a couple of days if nobody comments 
until then. Also Cc'd Dave, as he got probably the most experience with 
dv.

Regards,
Marton