[FFmpeg-devel] [PATCH 2/3] avformat/segafilm: Remove outdated check

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Wed Mar 24 02:53:53 EET 2021


The check has been added at a time when the code performed the
multiplication itself instead of deferring it to av_malloc_array()
and when our allocation functions used unsigned instead of size_t.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
 libavformat/segafilm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c
index 1225227138..675de00ed2 100644
--- a/libavformat/segafilm.c
+++ b/libavformat/segafilm.c
@@ -201,8 +201,6 @@ static int film_read_header(AVFormatContext *s)
         return AVERROR_INVALIDDATA;
     film->base_clock = AV_RB32(&scratch[8]);
     film->sample_count = AV_RB32(&scratch[12]);
-    if(film->sample_count >= UINT_MAX / sizeof(film_sample))
-        return -1;
     film->sample_table = av_malloc_array(film->sample_count, sizeof(film_sample));
     if (!film->sample_table)
         return AVERROR(ENOMEM);
-- 
2.27.0



More information about the ffmpeg-devel mailing list