[FFmpeg-devel] [PATCH 3/4] avfilter/asrc_sine: Fix invalid left shift of negative number

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Fri Mar 26 20:21:14 EET 2021


Nicolas George:
> Andreas Rheinhardt (12021-03-26):
>> Will apply.
> 
> Sorry, missed it.
> 

You have not missed anything.

> How does it impact the performance? Or even better: code? This code is
> meant to be as fast as possible.
> 

No impact whatsoever. Disassembly of request_frame is unchanged with
both GCC (10) and Clang (11) on O0-O3 (I was actually surprised about
O0, but not about the others.)
(If it were otherwise I would have opted for a different path (like
casting to unsigned).)

- Andreas


More information about the ffmpeg-devel mailing list