[FFmpeg-devel] [RFC PATCH] avformat/dashdec: Improve implementation

[Carl Eugen Hoyos]

Am Sa., 27. März 2021 um 17:45 Uhr schrieb Derek Buitenhuis
<derek.buitenhuis at gmail.com>:
>
> On 22/03/2021 22:25, zsugabubus wrote:
> > Compared to previous implementation, this rework tries to:
> >
> > - Improve code quality,
> > - Provide better error handling (also: reduce numerous (potential)
> >   memory leaks),
> > - Broader coverage of the standard:
> >   * multiple periods,
> >   * multiple base URLs (fallback on CDN failure),
> >   * handle ContentProtection/Role/etc... nodes,
> >   * manifest chaining,
> >   * drop ridiculous limits of @id's.
> > - Fast startup, thanks to reading/probing streams only when needed.
> > - Open multiple connections (HLS can open one more connection in
> >   advance; DASH can do up to UINT_MAX, configurable via option);
> >   similarly to HLS, currently it only opens them so only sequential
> >   reading is possible, however this behavior can be changed in the
> >   future,
> > - Ability to seek live streams.
> > - Bonus: Tests show that there are some kind of live streams that old
> >   implementation was unable to cope with, now it is possible to play
> >   them.
>
> These should be separate, testable, atomic commits. One massive
> patch that does 40 things is not reviewable or good for git history.

The patch clearly mentions that it is a "rework".
If the maintainer likes it, it would be nice if it can be simplified but
this may not be possible.

Carl Eugen