[FFmpeg-devel] [PATCH 37/39] doc/examples/extract_mvs: Explicitly free options

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Fri May 21 12:17:40 EEST 2021


The user should not rely on all options always being recognized
(in particular not on error).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
 doc/examples/extract_mvs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/doc/examples/extract_mvs.c b/doc/examples/extract_mvs.c
index 42e1844150..f5d2fd9179 100644
--- a/doc/examples/extract_mvs.c
+++ b/doc/examples/extract_mvs.c
@@ -104,7 +104,9 @@ static int open_codec_context(AVFormatContext *fmt_ctx, enum AVMediaType type)
 
         /* Init the video decoder */
         av_dict_set(&opts, "flags2", "+export_mvs", 0);
-        if ((ret = avcodec_open2(dec_ctx, dec, &opts)) < 0) {
+        ret = avcodec_open2(dec_ctx, dec, &opts);
+        av_dict_free(&opts);
+        if (ret < 0) {
             fprintf(stderr, "Failed to open %s codec\n",
                     av_get_media_type_string(type));
             return ret;
-- 
2.27.0



More information about the ffmpeg-devel mailing list