[FFmpeg-devel] [PATCH] avfilter/src_movie: fix always true expression

Valerii Zapodovnikov val.zapod.vz at gmail.com
Mon May 24 06:35:14 EEST 2021


Introduced in c1f9734f977f59bc0034096afbe8e43e40d93a5d.
We are in if (movie->seek_point > 0) but seek_point is timestamp.
---
 libavfilter/src_movie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c
index 54f6738f9a..105d1b7b54 100644
--- a/libavfilter/src_movie.c
+++ b/libavfilter/src_movie.c
@@ -252,7 +252,7 @@ static av_cold int movie_common_init(AVFilterContext *ctx)
         timestamp = movie->seek_point;
         // add the stream start time, should it exist
         if (movie->format_ctx->start_time != AV_NOPTS_VALUE) {
-            if (timestamp > 0 && movie->format_ctx->start_time > INT64_MAX - timestamp) {
+            if (movie->format_ctx->start_time > INT64_MAX - timestamp) {
                 av_log(ctx, AV_LOG_ERROR,
                        "%s: seek value overflow with start_time:%"PRId64" seek_point:%"PRId64"\n",
                        movie->file_name, movie->format_ctx->start_time, movie->seek_point);
-- 
2.30.2



More information about the ffmpeg-devel mailing list