[FFmpeg-devel] [PATCH] avfilter/vf_subtitles: allow using embedded fonts

[Oneric]

On Sat, May 29, 2021 at 22:54:44 +0530, Gyan Doshi wrote:
> On 2021-05-29 22:14, Oneric wrote:
> > On Sat, May 29, 2021 at 11:53:24 +0530, Gyan Doshi wrote:
> > > Would it make sense to allow users to not load embedded fonts?
> >
> > I can't think of a reason not to load embedded fonts in ffmpeg; they are
> > required to render subs as intended by the sub author. Without them some
> > fallback font from the system or mkv-attachments will be used instead
> > (which if the requested font doesn't by chance happen to also be available
> >   on the system or as a container-attachment, will be some, more or
> >   less random font).
> > VLC always enables this unconditionally, but mplayer and mpv have an option
> > for this defaulting to embedded fonts enabled, but as before I don't know why
> > anyone would want to disable this.
> 
> Security reasons?

If one expects processing a font file to expose (relevantly) more
attack surface, or be more dangerous than the rest of untrusted ASS
files, than perhaps yes.
Otherwise, I at least can't think of something right now.

Cheers
Oneric