[FFmpeg-devel] [PATCH] */version.h: define FF_API macros unconditionally

[Anton Khirnov]

Quoting Hendrik Leppkes (2021-11-12 14:59:41)
> On Fri, Nov 12, 2021 at 2:35 PM Anton Khirnov <anton at khirnov.net> wrote:
> >
> > There is no reason to wrap them in #ifndef guards, they should only be
> > defined here and nowhere else. The define guards just add the
> > possibility to accidentally use the same FF_API name in different
> > libraries.
> 
> Wasn't the idea here that I can just define one to true on
> commandline/configure to test its removal?
> Not sure if anyone really does that anymore, but at least back in the
> day that was a thing ... sometimes used.

I have never heard of anyone doing that - I always just modify the value
directly when I want to test things.

And I did discover duplicate values during the recent bump, so it's not
a theoretical issue.

-- 
Anton Khirnov