[FFmpeg-devel] [PATCH 3/4] avfilter/vf_huesaturation: Remove dead store

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Thu Nov 18 11:13:56 EET 2021


Fixes Coverity issue #1493345.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
The x = y also looks strange. Why does the parameter x exist at all
if it is immediately overwritten in the function?

 libavfilter/vf_huesaturation.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libavfilter/vf_huesaturation.c b/libavfilter/vf_huesaturation.c
index af7ea33b9e..d4e3fea1c5 100644
--- a/libavfilter/vf_huesaturation.c
+++ b/libavfilter/vf_huesaturation.c
@@ -297,7 +297,6 @@ static void transform_point(float matrix[4][4],
                             float *tx, float *ty, float *tz)
 {
     x = y;
-    *tx = x;
     *tx = x * matrix[0][0] + y * matrix[1][0] + z * matrix[2][0] + matrix[3][0];
     *ty = x * matrix[0][1] + y * matrix[1][1] + z * matrix[2][1] + matrix[3][1];
     *tz = x * matrix[0][2] + y * matrix[1][2] + z * matrix[2][2] + matrix[3][2];
-- 
2.30.2



More information about the ffmpeg-devel mailing list